PDO: Migrate maxlen of pdo_column_data from size_t to zend_long #19144
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 28, 2025
| @@ -533,7 +533,7 @@ static inline pdo_dbh_object_t *php_pdo_dbh_fetch_object(zend_object *obj) { | |||
| /* describes a column */ | |||
| struct pdo_column_data { | |||
| zend_string *name; | |||
| size_t maxlen; | |||
| zend_long maxlen; | |||
There was a problem hiding this comment.
Wouldn't this be more accurate?
Suggested change
| zend_long maxlen; | |
| ssize_t maxlen; |
|
Hmm... It seems that in pdo_odbc, a ulong value is passed here (according to the ODBC specification, an unsigned 64-bit integer might be passed). php-src/ext/pdo_odbc/odbc_stmt.c Line 614 in eaf24ba I suppose such columns are quite rare in practice, but this does introduce a slight possibility of a BC break. One alternative might be to add a flag instead of changing the type to signed. What do you think? @NattyNarwhal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is returned in PDOStatement::getColumnMeta as
lendocumented as "The length of this column. Normally -1 for types other than floating point decimals."Also, It was as
FIXMEalready.PQfsize: returns the space allocated for this column in a database row, in other words the size of the server's internal representation of the data type. (Accordingly, it is not really very useful to clients.) A negative value indicates the data type is variable-length.dbcollen: The maximum length, in bytes, of the data for the particular column. If the column number is not in range, dbcollen returns -1.XSQLVAR.sqllen->ISC_SHORT->signed short: length of data areaMYSQL_FIELD.lengthMYSQLND_FIELD.length->zend_ulong: Width of column (create length)unsigned long length: Width of column (create length)I noticed this during my work of 64bit integers on 32bit arch where it would was failing: https://github.com/php/php-src/actions/runs/16311803646/job/46068812948#step:9:2782